Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use date display field for card dates #14619

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther force-pushed the fix/51858/use-date-display-field-card branch 2 times, most recently from bcf3468 to ac2aa3c Compare January 22, 2024 12:28
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timezone issue is correctly fixed. However, there are some things that do not work correctly/like before:

  • When start and end date are the same, the card abbeviated that before. Now it writes the date twice:
Bildschirmfoto 2024-01-23 um 01 43 32 Bildschirmfoto 2024-01-23 um 01 44 10
  • When there is only a start date set, the card should show DATE - . Now it is only showing the dash:
Bildschirmfoto 2024-01-23 um 01 40 35

@HDinger HDinger added this to the 13.2.x milestone Jan 22, 2024
@oliverguenther
Copy link
Member Author

oliverguenther commented Jan 22, 2024

Bildschirmfoto 2024-01-22 um 16 16 49

Thanks for the feedback. They now show all cases correctly. single view and card is now consistent with the wanted exceptions of:

  • The placeholder being empty for cards, but - for single view
  • The long month names

The cards also now show milestone dates correctly, which wasn't the case before

@oliverguenther oliverguenther force-pushed the fix/51858/use-date-display-field-card branch from 6e16e37 to 8af42d2 Compare January 22, 2024 15:32
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes affect not only the cards but also the WP view. I assume, that this is not wanted, but we might have to double check with the product team.

Before
Bildschirmfoto 2024-01-23 um 08 43 22
Bildschirmfoto 2024-01-23 um 08 43 12

After
Bildschirmfoto 2024-01-23 um 08 41 42
Bildschirmfoto 2024-01-23 um 08 42 17

@oliverguenther oliverguenther force-pushed the fix/51858/use-date-display-field-card branch 2 times, most recently from d558019 to e548171 Compare January 24, 2024 07:32
@oliverguenther
Copy link
Member Author

@HDinger I've restored previous behavior with the exception of when the dates are equal. It is reduced to a single value then which I think makes sense.

@HDinger
Copy link
Contributor

HDinger commented Jan 25, 2024

@HDinger I've restored previous behavior with the exception of when the dates are equal. It is reduced to a single value then which I think makes sense.

I am not so sure about this, especially since the highlighting is lost. Before the, due date was highlighted if it is today or in the past. With the current solution this is lost. I guess it is sufficient if we re-add the highlighting to the date, but I guess we should double check with the product team.
Bildschirmfoto 2024-01-23 um 08 43 12

Bildschirmfoto 2024-01-24 um 22 34 09

@oliverguenther oliverguenther force-pushed the fix/51858/use-date-display-field-card branch from e6683f8 to 0ffbc5a Compare January 25, 2024 12:27
@oliverguenther oliverguenther merged commit 5d31cbb into release/13.2 Jan 25, 2024
11 checks passed
@oliverguenther oliverguenther deleted the fix/51858/use-date-display-field-card branch January 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants