Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make open project running under Ruby 3.3 #14853

Closed
wants to merge 3 commits into from

Conversation

Eric-Guo
Copy link
Contributor

Just fix Anonymous block parameter is also used within block (SyntaxError)

@Eric-Guo Eric-Guo marked this pull request as draft February 26, 2024 06:36
@Eric-Guo Eric-Guo force-pushed the remove_anonymous_block branch from 3bef52a to f555e97 Compare February 26, 2024 06:43
@Eric-Guo Eric-Guo force-pushed the remove_anonymous_block branch from f555e97 to f7675f6 Compare February 26, 2024 06:58
@Eric-Guo Eric-Guo marked this pull request as ready for review February 26, 2024 07:15
@klaustopher
Copy link
Contributor

Hey @Eric-Guo, looking into the issue a bit more, there has been a discussion in the Rubocop repo and the current errors that are shown are due to a bug in Ruby 3.3.0 and this will be fixed in 3.3.1. See https://bugs.ruby-lang.org/issues/20090. Issues like those are why we have not upgraded the Ruby version for OpenProject yet.

As soon as 3.3.1 is out, we will re-evaluate if we can switch over to the new version.

Could I ask what your specific use case is to force OP to run under 3.3?

@Eric-Guo
Copy link
Contributor Author

Eric-Guo commented Feb 26, 2024

Not yet, the reason to change is just because I using Mac and brew to install ruby and ruby version is 3.3, without this PR, I can not start up the OP in my local env. 😃

@ulferts
Copy link
Contributor

ulferts commented Feb 26, 2024

Hi @Eric-Guo,

most people on a Mac developing OpenProject use something like rbenv for managing the ruby version. Would that be an option for you in the meantime?

Regards
Jens

@Eric-Guo
Copy link
Contributor Author

Eric-Guo commented Feb 26, 2024

Yeah, but I'm still prefer one ruby version for all (10+ rails) projects I maintained, anyway I'm glad to known openproject know this issue better than me.

@Eric-Guo Eric-Guo closed this Feb 26, 2024
@Eric-Guo Eric-Guo deleted the remove_anonymous_block branch February 26, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants