Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attachments on meetings for agenda items #14862

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

oliverguenther
Copy link
Member

  • Introduces a meetings API so it can be plugged into the attachable mixin for uploading files, as agenda items are not journalized itself, but only in the meeting container
  • Extend the primer rich text input so that it can receive a resource

https://community.openproject.org/work_packages/26819

Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments. I tried to check the documentation at the /api/docs and the newly added api information do not show up, probably we need to add them to the dev/docs/api/apiv3/openapi-spec.yml.

docs/api/apiv3/paths/meeting_attachments.yml Outdated Show resolved Hide resolved
docs/api/apiv3/paths/meeting_attachments.yml Outdated Show resolved Hide resolved
docs/api/apiv3/paths/meeting_attachments.yml Outdated Show resolved Hide resolved
docs/api/apiv3/paths/meeting_attachments.yml Outdated Show resolved Hide resolved
docs/api/apiv3/paths/meeting_attachments.yml Outdated Show resolved Hide resolved
docs/api/apiv3/paths/meeting_attachments.yml Outdated Show resolved Hide resolved
@oliverguenther oliverguenther force-pushed the feature/meetings-attachments branch from c58b40a to 3e3f2bc Compare March 5, 2024 07:57
@oliverguenther oliverguenther force-pushed the feature/meetings-attachments branch from 3e3f2bc to bef4fe0 Compare March 5, 2024 08:14
@oliverguenther oliverguenther merged commit 24310f2 into dev Mar 5, 2024
13 checks passed
@oliverguenther oliverguenther deleted the feature/meetings-attachments branch March 5, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants