Introduces the CopyProjectFolderJob #14892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mereghost
force-pushed
the
impl/split-storage-jobs
branch
from
2729a4a to
bcf95e7
Compare
mereghost
force-pushed
the
impl/split-storage-jobs
branch
from
bcf95e7 to
f53190e
Compare
Kharonus
requested changes
Mar 6, 2024
...pp/common/storages/peripherals/storage_interaction/one_drive/copy_template_folder_command.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/services/projects/copy/storage_project_folders_dependent_service.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/services/projects/copy/storage_project_folders_dependent_service.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/services/storages/file_links/copy_file_links_service.rb
Show resolved
Hide resolved
| attributes['creator_id'] = @user.id | ||
| attributes['container_id'] = @work_packages_map[source_file_link.container_id] | ||
|
|
||
| # TODO: Do something when this fails |
There was a problem hiding this comment.
🟡 resolve todo? 😁
This is not part of current implementation, I know. What should we do?
CopyFileLinksService seems to not return a ServiceResult right now. Should it return one and log the included failures from the caller?
Or simply log the failures when the creation fails.
There was a problem hiding this comment.
That was part of the feedback I wanted. I think for now I'll just log the errors.
We need to decide on what to return when some object does multiple operations, some of which might fail but not be catastrophic. A success with errors feels about right, but I'm no sure. Same goes of for having a result on a failure, feels correct but... idk.
mereghost
force-pushed
the
impl/split-storage-jobs
branch
from
b6ff58d to
24af3be
Compare
akabiru
previously approved these changes
Mar 6, 2024
modules/storages/app/services/storages/file_links/copy_file_links_service.rb
Show resolved
Hide resolved
modules/storages/app/workers/storages/copy_project_folders_job.rb
Outdated
Show resolved
Hide resolved
modules/storages/app/workers/storages/copy_project_folders_job.rb
Outdated
Show resolved
Hide resolved
mereghost
force-pushed
the
impl/split-storage-jobs
branch
2 times, most recently
from
6e273b9 to
75dfe3a
Compare
mereghost
force-pushed
the
impl/split-storage-jobs
branch
2 times, most recently
from
f301189 to
1391c36
Compare
mereghost
force-pushed
the
impl/split-storage-jobs
branch
from
1391c36 to
8856f81
Compare
mereghost
force-pushed
the
impl/split-storage-jobs
branch
from
8856f81 to
1aa09a2
Compare
|
PR #15054 includes this one and supersedes it. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate Work Package: OP#53035
What?
Due to the need of polling for OneDrive we have split the copy and file link setup process from the main
ProjectCopyservice.How?
I introduced a new job and a couple of new services, deprecating the already existing ones.
More details, tonight at OpenProject News. 🤣