Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53309] Reduce configurable design variables #14942

Merged

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Mar 7, 2024

Todo

In Administration / Design:

  • The colour token Primary dark is removed. A darker variant for hover effects is calculated automatically
  • Alternative colour tokens will be renamed to Primary button.
  • The colour token Primary is removed as well. It is replaced by the new Primary button
    • Merge the button options "-alt-highlight" and "-highlight" into one "-primary" button style using the Primary button token.
    • Introduce an (internal) variable for highlighting controls (toggle buttons, datepicker selection etc). This will be calculated based on the link color.
  • Link font will be renamed to Accent as it will be the base for other calculated variables (e.g for checked controls as the toggle)

Test checklist

  • pre-defined Themes (Normal, Light, Dark, BIM)
  • Custom design
  • Fresh seed

https://community.openproject.org/projects/openproject/work_packages/53309/activity

@HDinger HDinger force-pushed the feature/53309-reduce-configurable-design-variables branch 2 times, most recently from 86c0c7e to e61d114 Compare March 8, 2024 09:38
@HDinger HDinger marked this pull request as ready for review March 8, 2024 13:09
@HDinger HDinger force-pushed the feature/53309-reduce-configurable-design-variables branch from e61d114 to e134e08 Compare March 8, 2024 13:10
@oliverguenther oliverguenther merged commit d7f336d into dev Mar 8, 2024
13 checks passed
@oliverguenther oliverguenther deleted the feature/53309-reduce-configurable-design-variables branch March 8, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants