Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PostgreSQL unaccent extension und use it for user filters #14968

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

oliverguenther
Copy link
Member

https://community.openproject.org/work_packages/53371

I first looked at the ICU collations, but they have their own drackbacks, so I went to the unaccent core/contrib extension instead. We're currently not using and indexes on the concatenated user fields anyway, so the impact should not bee to bad. I've tested this on the public community dump for adequate sized user collection prior to filtering.

See also for more information on ICU and different approaches and their drawbacks: https://stackoverflow.com/a/11007216/420614

Assigning to 13.5 due to the added migration

@oliverguenther oliverguenther force-pushed the fix/53371/unaccent-user-names branch 2 times, most recently from aad4263 to 688e099 Compare March 11, 2024 12:32
@klaustopher
Copy link
Contributor

Would we need something in our container setup to include postgres-contrib, or is it already available?

@oliverguenther oliverguenther force-pushed the fix/53371/unaccent-user-names branch from 7d0b262 to 49b0988 Compare March 11, 2024 13:49
@oliverguenther
Copy link
Member Author

Would we need something in our container setup to include postgres-contrib, or is it already available?

we already have other extensions enabled from this package, which is shipped with in most distributions (and docker), but was missing in e.g, RHEL. There it has to be enabled manually, but most installations will have done so already due to older migrations.

@oliverguenther oliverguenther force-pushed the fix/53371/unaccent-user-names branch 2 times, most recently from e13b562 to f3195ef Compare March 11, 2024 14:23
@oliverguenther oliverguenther force-pushed the fix/53371/unaccent-user-names branch from f3195ef to bd305c7 Compare March 11, 2024 19:28
@oliverguenther oliverguenther merged commit 1f28a37 into dev Mar 11, 2024
9 checks passed
@oliverguenther oliverguenther deleted the fix/53371/unaccent-user-names branch March 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants