Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use capability to identify whether work package create button is available #15024

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Mar 18, 2024

@oliverguenther oliverguenther changed the title Don't subscribe to subsequent updates of the work_package model auth Fix useless disabling of wp-create-button Mar 18, 2024
@dombesz dombesz self-requested a review March 20, 2024 10:00
@oliverguenther oliverguenther force-pushed the fix/49136/create-button-disabled branch from dbdf292 to 75bbcbf Compare April 17, 2024 13:56
@oliverguenther oliverguenther changed the base branch from dev to release/14.0 April 17, 2024 14:01
@oliverguenther oliverguenther changed the title Fix useless disabling of wp-create-button Use capability to identify whether work package create button is available Apr 17, 2024
@oliverguenther oliverguenther force-pushed the fix/49136/create-button-disabled branch from 75bbcbf to 34c77bc Compare April 18, 2024 09:03
@oliverguenther oliverguenther requested a review from dombesz April 18, 2024 11:25
@oliverguenther
Copy link
Member Author

@dombesz I rewrote the check using the capabilities API instead of relying on model links, which might change when creating children.

Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dombesz dombesz merged commit 5c9220c into release/14.0 Apr 18, 2024
7 checks passed
@dombesz dombesz deleted the fix/49136/create-button-disabled branch April 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants