Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add proper api spec schema for Available_AssigneesModel #15452

Merged
merged 1 commit into from
May 3, 2024
Merged

[chore] Add proper api spec schema for Available_AssigneesModel #15452

merged 1 commit into from
May 3, 2024

Conversation

sbu-WBT
Copy link
Contributor

@sbu-WBT sbu-WBT commented May 2, 2024

I took attachments_model.yml as a template; hopefully everything's alright

ulferts
ulferts approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sbu-WBT. Thanks for taking the time.

It would be nice to also have an example but it is definitely better to get the specification correct than to have examples.

@ulferts ulferts merged commit 17dfeaa into opf:dev May 3, 2024
5 checks passed
@sbu-WBT sbu-WBT deleted the openapi/Available_AssigneesModel branch May 4, 2024 10:44
@sbu-WBT
Copy link
Contributor Author

sbu-WBT commented May 4, 2024

Do you know in which collection is currently an example? I will add it next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulferts ulferts ulferts approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbu-WBT @ulferts