-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code maintenance/53379 separate filtering from projections in queries #15662
Draft
ulferts
wants to merge
28
commits into
dev
Choose a base branch
from
code-maintenance/53379-separate-filtering-from-projections-in-queries
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Code maintenance/53379 separate filtering from projections in queries #15662
ulferts
wants to merge
28
commits into
dev
from
code-maintenance/53379-separate-filtering-from-projections-in-queries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.joins("LEFT JOIN (#{wiki_storage_sql}) wiki ON projects.id = wiki.project_id") | ||
.joins("LEFT JOIN (#{work_package_sql}) wp ON projects.id = wp.project_id") | ||
.joins("LEFT JOIN #{Repository.table_name} repos ON repos.project_id = projects.id") | ||
.joins("LEFT JOIN (#{wiki_storage_sql}) wiki_size ON projects.id = wiki_size.project_id") |
Check warning
Code scanning / Brakeman
Possible SQL injection. Warning
Possible SQL injection.
ulferts
force-pushed
the
code-maintenance/53379-separate-filtering-from-projections-in-queries
branch
4 times, most recently
from
May 30, 2024 16:09
84d12a2
to
5564ae5
Compare
ulferts
force-pushed
the
code-maintenance/53379-separate-filtering-from-projections-in-queries
branch
11 times, most recently
from
July 1, 2024 08:40
37710f9
to
bb84895
Compare
ulferts
force-pushed
the
code-maintenance/53379-separate-filtering-from-projections-in-queries
branch
3 times, most recently
from
July 12, 2024 10:24
269fe6e
to
10f8908
Compare
ulferts
force-pushed
the
code-maintenance/53379-separate-filtering-from-projections-in-queries
branch
3 times, most recently
from
August 16, 2024 08:30
d54bff0
to
9d4cf1c
Compare
ulferts
force-pushed
the
code-maintenance/53379-separate-filtering-from-projections-in-queries
branch
from
August 16, 2024 13:21
9d4cf1c
to
64bc47e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors with the following goals:
select
s chosen to be displayed can be made responsible for fetching additional information (e.g. by joining another table and selecting values from there) instead of doing it within the query itself or in the table component. This also allows for a more dynamic approach for fetching data. i.e. only when displaying thelatest_activity_at
column is that information actually computedTodos
https://community.openproject.org/wp/53379
https://community.openproject.org/wp/53315