Put all sharing functionality into the scoped route and an extractable route concern #15843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaustopher
force-pushed
the
rework-membership-on-global-entities
branch
from
dfc0675 to
a6c3e2e
Compare
klaustopher
force-pushed
the
extract-sharing-functionality
branch
from
bade143 to
03211f3
Compare
klaustopher
force-pushed
the
rework-membership-on-global-entities
branch
from
a6c3e2e to
dc7002c
Compare
klaustopher
force-pushed
the
extract-sharing-functionality
branch
from
03211f3 to
d15b16b
Compare
klaustopher
force-pushed
the
extract-sharing-functionality
branch
from
d15b16b to
8724a8a
Compare
klaustopher
changed the title
klaustopher
force-pushed
the
extract-sharing-functionality
branch
2 times, most recently
from
ae01041 to
36addd8
Compare
klaustopher
force-pushed
the
extract-sharing-functionality
branch
from
36addd8 to
bd1df60
Compare
oliverguenther
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the routes for the sharing model are scattered in a few places. We can put them into one controller and one route resource so we can make a route concern out of this and re-use it later in other places (i.e. project queries)
Part of https://community.openproject.org/projects/openproject/work_packages/55162