Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#55771] Warn user that the type is not available when moving a work package #15887

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

aaron-contreras
Copy link
Contributor

Displays a warning toast letting the user know to activate the current types of the work packages under move in the target project and making the "auto-reassign" behavior known to them so they can better take a decision when performing moves.

See: https://community.openproject.org/work_packages/55771

Displays a warning toast letting the user know to activate the current
types of the work packages under move in the target project and
making the "auto-reassign" behavior known to them so they can better
take a decision when performing moves.
@aaron-contreras aaron-contreras self-assigned this Jun 18, 2024
@aaron-contreras aaron-contreras added this to the 14.3.x milestone Jun 18, 2024
@aaron-contreras aaron-contreras marked this pull request as ready for review June 18, 2024 15:36
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning seems to be coming on, even if I don't change anything on the move form yet.

Bug Demo

Jun-20-2024 10-16-32

Just an observation,the toast seems to have no space on top. Please ignore it if that's the intended look.

image

@aaron-contreras
Copy link
Contributor Author

The warning seems to be coming on, even if I don't change anything on the move form yet.

I see this as being correct though, it's warning you if you haven't done anything because not doing anything will cause the type to be automatically re-assigned.

Just an observation,the toast seems to have no space on top. Please ignore it if that's the intended look.

There were no visuals for it but I wanted to make it seem tied to the field above and not just floating around 😅 . Do you have another idea?

@aaron-contreras aaron-contreras requested a review from dombesz June 20, 2024 14:45
@aaron-contreras aaron-contreras requested a review from dombesz June 20, 2024 18:48
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Aaron! 👍

@dombesz dombesz merged commit 09b3a68 into dev Jun 24, 2024
8 checks passed
@dombesz dombesz deleted the bug/55771-type-gets-automatically-change-on-move-project branch June 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants