Handle errors when Copying Project Folders when the Storage is broken #15893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Nextcloud to use the same interface
mereghost
force-pushed
the
bug/no-method-for-symbol
branch
from
3226cba to
a767385
Compare
Kharonus
approved these changes
Jun 20, 2024
| @@ -33,28 +33,27 @@ module Nextcloud | |||
| class CopyTemplateFolderCommand | |||
| using ServiceResultRefinements | |||
|
|
|||
| def self.call(storage:, source_path:, destination_path:) | |||
| new(storage).call(source_path:, destination_path:) | |||
| def self.call(auth_strategy:, storage:, source_path:, destination_path:) | |||
There was a problem hiding this comment.
🟢 good thing I saw that now, was going to start with that command almost myself.
| @@ -42,6 +42,7 @@ def perform(source:, target:, work_packages_map:) | |||
| user = batch.properties[:user] | |||
|
|
|||
| project_folder_result = results_from_polling || initiate_copy(target) | |||
| project_folder_result.on_failure { |failed| return log_failure(failed) } | |||
There was a problem hiding this comment.
❓ so, this is the actual fix, the rest is boyscouting, right? Or did I miss another piece of changes?
There was a problem hiding this comment.
Yep, this is the entire fix, the rest was just a case of "Ok, since I'm here already..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related WP: OP#55805
What?
I hadn't handled the issue of trying to copy a project folder on a broken storage. This PR aims to fix that.
How?
Well... by handling the service result failure. =/
This PR also:
auth_strategytoCopyTemplateFolderCopyTemplateFolder