Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRUD API endpoints for news #15925

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add CRUD API endpoints for news #15925

merged 1 commit into from
Jun 25, 2024

Conversation

oliverguenther
Copy link
Member

cbliard
cbliard approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

The code looks nice. I only have remarks about the API documentation. Feel free to merge anytime when you're done.

docs/api/apiv3/components/schemas/news_create_model.yml Outdated Show resolved Hide resolved
docs/api/apiv3/components/schemas/news_create_model.yml Outdated Show resolved Hide resolved
docs/api/apiv3/components/schemas/news_create_model.yml Outdated Show resolved Hide resolved
docs/api/apiv3/components/schemas/news_create_model.yml Outdated Show resolved Hide resolved
docs/api/apiv3/paths/news_item.yml Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
@oliverguenther
Copy link
Member Author

Thanks @cbliard, I've addressed all remarks

@oliverguenther oliverguenther merged commit 25f6994 into dev Jun 25, 2024
10 checks passed
@oliverguenther oliverguenther deleted the feature/news-api branch June 25, 2024 12:38
@toy toy mentioned this pull request Jun 25, 2024
Merged
@ulferts ulferts mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbliard cbliard cbliard approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverguenther @cbliard @dombesz