Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#55899] refactor rename files command #15950

Merged
merged 3 commits into from
Jun 26, 2024
Merged

[#55899] refactor rename files command #15950

merged 3 commits into from
Jun 26, 2024

Conversation

Kharonus
Copy link
Member

#55899

WAT?

  • use authentication strategies in rename files commands
  • harmonize command interface
    • input data is now file id and new name
    • output is always a storage file in success case
  • use shared tests to enforce common interface

Trivia

  • before nextcloud command used pathes and one drive used id and name
  • new format is id + name for both, this required nextcloud query to make a preflight and postflight request
  • changes to nextcloud command made some changes in sync service necessary ⚠️

@Kharonus
[#55899] refactor rename files command
9906600 
- https://community.openproject.org/wp/55899
- use authentication strategies in rename files commands
- harmonize command interface
  - input data is now file id and new name
  - output is always a storage file in success case
- use shared tests to enforce common interface
@Kharonus Kharonus self-assigned this Jun 24, 2024
@Kharonus Kharonus requested review from mereghost and a team June 25, 2024 12:42
mereghost
mereghost approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@mereghost mereghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work there.

modules/storages/spec/support/shared_examples_for_adapters/rename_file_command_examples.rb Show resolved Hide resolved
modules/storages/spec/services/storages/nextcloud_group_folder_properties_sync_service_spec.rb Show resolved Hide resolved
@Kharonus Kharonus merged commit 5937c3d into dev Jun 26, 2024
8 checks passed
@Kharonus Kharonus deleted the implementation/55899-use-authentication-in-rename_files_command branch June 26, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mereghost mereghost mereghost approved these changes

Assignees

@Kharonus Kharonus

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kharonus @mereghost