[#55950] updated documentation for storage health checks #15981
reviewdog [rubocop] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (79)
app/controllers/my_controller.rb|138 col 3| Assignment Branch Condition size for generate_rss_key is too high. [<4, 18, 1> 18.47/17]
app/controllers/my_controller.rb|263 col 31| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
lib_static/open_project/acts/watchable.rb|134 col 33| Redundant safe navigation detected, use .
instead.
lib_static/open_project/acts/watchable.rb|143 col 31| Prefer keyword arguments for arguments with a boolean default value; use watching: true
instead of watching = true
.
lib_static/open_project/acts/watchable.rb|159 col 59| Use any?(user.id)
instead of block.
lib_static/open_project/acts/watchable.rb|160 col 32| Use any?(user.id)
instead of block.
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|105 col 9| Assignment Branch Condition size for custom_field_values= is too high. [<5, 17, 8> 19.44/17]
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|105 col 9| Perceived complexity for custom_field_values= is too high. [9/8]
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|174 col 30| Method parameter must be at least 3 characters long.
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|185 col 36| Method parameter must be at least 3 characters long.
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|198 col 40| Method parameter must be at least 3 characters long.
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|265 col 9| Assignment Branch Condition size for custom_field_changes is too high. [<5, 15, 10> 18.71/17]
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|265 col 9| Perceived complexity for custom_field_changes is too high. [9/8]
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb|366 col 15| Use safe navigation (&.
) instead of checking if an object exists before calling the method.
lib_static/plugins/acts_as_event/lib/acts_as_event.rb|85 col 11| Convert if-elsif
to case-when
.
lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb|43 col 9| Assignment Branch Condition size for acts_as_searchable is too high. [<10, 40, 8> 42/17]
lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb|43 col 9| Perceived complexity for acts_as_searchable is too high. [9/8]
lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb|84 col 11| Assignment Branch Condition size for search is too high. [<17, 63, 12> 66.35/17]
lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb|84 col 11| Perceived complexity for search is too high. [13/8]
lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb|110 col 131| Line is too long. [137/130]
lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb|125 col 131| Line is too long. [168/130]
spec/controllers/my_controller_spec.rb|57 col 9| Prefer expect(response).to have_http_status(404)
over expect(response.status).to eq 404
.
spec/controllers/my_controller_spec.rb|99 col 48| Avoid instance variables - use let, a method call, or a local variable (if possible).
spec/controllers/my_controller_spec.rb|179 col 9| Prefer using be_auto_hide_popups
matcher over auto_hide_popups?
.
spec/controllers/my_controller_spec.rb|245 col 5| Empty example group detected.
spec/controllers/my_controller_spec.rb|245 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb|146 col 11| Use receive_messages
instead of multiple stubs on lines [150].
spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb|150 col 11| Use receive_messages
instead of multiple stubs on lines [146].
spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb|183 col 11| Use receive_messages
instead of multiple stubs on lines [187].
spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb|187 col 11| Use receive_messages
instead of multiple stubs on lines [183].
spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb|220 col 11| Use receive_messages
instead of multiple stubs on lines [224].
spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb|224 col 11| Use receive_messages
instead of multiple stubs on lines [220].
spec/models/attachment_spec.rb|175 col 12| Use described_class
instead of Attachment
.
spec/models/attachment_spec.rb|178 col 12| Use described_class
instead of Attachment
.
spec/models/attachment_spec.rb|194 col 7| Do not use expect
in before
hook
spec/models/attachment_spec.rb|366 col 19| Prefer have_received
for setting message expectations. Setup Attachments::ExtractFulltextJob
as a spy using allow
or instance_spy
.
spec/models/attachment_spec.rb|389 col 7| Repeated context block body on line(s) [393]
spec/models/attachment_spec.rb|393 col 7| Repeated context block body on line(s) [389]
spec/models/user_spec.rb|102 col 22| Use expect(...).not_to be_valid
.
spec/models/user_spec.rb|111 col 22| Use expect(...).not_to be_valid
.
spec/models/user_spec.rb|223 col 16| Use find_by
instead of dynamic find_by_login
.
spec/models/user_spec.rb|224 col 16| Use find_by
instead of dynamic find_by_unique
.
spec/models/user_spec.rb|387 col 7| Use receive_messages
instead of multiple stubs on lines [388].
spec/models/user_spec.rb|388 col 7| Use receive_messages
instead of multiple stubs on lines [387].
spec/models/user_spec.rb|521 col 21| Prefer using verifying doubles over normal doubles.
spec/models/user_spec.rb|522 col 7| Use receive_messages
instead of multiple stubs on lines [523, 524, 525].
spec/models/user_spec.rb|523 col 7| Use receive_messages
instead of multiple stubs on lines [522, 524, 525].
spec/models/user_spec.rb|524 col 7| Use receive_messages
instead of multiple stubs on lines [522, 523, 525].
spec/models/user_spec.rb|525 col 7| Use receive_messages
instead of multiple stubs on lines [522, 523, 524].
spec/models/user_spec.rb|528 col 7| Prefer allow
over expect
when configuring a response.
spec/models/user_spec.rb|528 col 30| Prefer have_received
for setting message expectations. Setup user_double
as a spy using allow
or instance_spy
.
spec/models/user_spec.rb|559 col 11| Do not use expect
in before
hook
spec/models/user_spec.rb|559 col 11| Prefer allow
over expect
when configuring a response.
spec/models/user_spec.rb|559 col 34| Prefer have_received
for setting message expectations. Setup auth_source
as a spy using allow
or instance_spy
.
spec/models/user_spec.rb|570 col 11| Do not use expect
in before
hook
spec/models/user_spec.rb|570 col 11| Prefer allow
over expect
when configuring a response.
spec/models/user_spec.rb|570 col 34| Prefer have_received
for setting message expectations. Setup auth_source
as a spy using allow
or instance_spy
.
spec/models/user_spec.rb|659 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|673 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|676 col 9| Do not use expect
in before
hook
spec/models/user_spec.rb|676 col 40| Avoid instance variables - use let, a method call, or a local variable (if possible).
spec/models/user_spec.rb|682 col 37| Avoid instance variables - use let, a method call, or a local variable (if possible).
spec/models/user_spec.rb|697 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|705 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|715 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|724 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|737 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|742 col 19| Use find_by
instead of dynamic find_by_rss_key
.
spec/models/user_spec.rb|745 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/user_spec.rb|750 col 19| Use find_by
instead of dynamic find_by_rss_key
.
spec/models/user_spec.rb|836 col 18| Use find_by
instead of dynamic find_by_mail
.
spec/models/user_spec.rb|851 col 18| Use find_by
instead of dynamic find_by_mail
.
spec/models/user_spec.rb|855 col 18| Use find_by
instead of dynamic find_by_mail
.
spec/models/user_spec.rb|942 col 16| Use find_by
instead of dynamic find_by_api_key
.
spec/models/user_spec.rb|949 col 16| Use find_by
instead of dynamic find_by_api_key
.
spec/models/user_spec.rb|958 col 16| Use find_by
instead of dynamic find_by_api_key
.
spec/models/user_spec.rb|977 col 16| Use find_by
instead of dynamic find_by_mail
.
spec/models/user_spec.rb|984 col 16| Use find_by
instead of dynamic find_by_mail
.
spec/models/user_spec.rb|993 col 16| Use find_by
instead of dynamic find_by_mail
.