Implementation/53233 replace sidemenu of work package page with rails component

[HDinger]

ToDo

• Use Common::SubmenuComponent to render the submenu of the WorkPackages module
• Follow the same code structure we introduced recently for the other modules
• Take care that all of the special default queries are correctly highlighted ("all open", "summary", etc)
• Get tests green
• Remove op-view-select and reduce the op-static-queries.service to the functionality of gettting the name of the query but not building them any more.

https://community.openproject.org/projects/openproject/work_packages/53233/activity

By chance, this also fixes https://community.openproject.org/projects/openproject/work_packages/52954/activity and https://community.openproject.org/projects/openproject/work_packages/52759/activity

[cbliard]

I did not look at the code yet.

I found the following issues with the work package sidebar menu:

• When displaying the menu when clicking on the arrow next to "Work packages", multiple items are selected/highlighted, but none should be highlighted

  1. Go to a project > Overview
  2. In the side bar menu, click the arrow next to "Work packages"
  • => expected: nothing highlighted (can be checked on qa.openproject-stage.com)
  • => actual: "Project plan" and "All open" are highlighted
  • Note: The one on "Project plan" seems to vanish when focusing somewhere else, like clicking in the search bar
  • 

• When modifying filters, the selected menu item is still hightlighted. But I'm not sure if that's wanted or if it's a regression compared to before:

  1. Go to project > Work packages > All open
  2. Change filter status from "status = open" to "status = closed".
  • => expected: nothing highlighted as the filters have been changed and a little "save" icon is displayed (at least, that's the behavior on qa.openproject-stage.com)
  • => actual: the "All open" menu item remains highlighted.
  • Note: the behavior on stage is not ideal either as the highlighted menu item is easily lost, even without modifying anything on the filters (for instance on stage, click "All open", then "Latest activity", then click in the blank area below the work package table => menu item is unselected and the little save icon is shown, but it should not be).

And what works well 👍 :

• renaming a view => renamed in menu
• saving as a view => a new item is created in menu
• deleting a view => view is removed
• changing visibility => collapsible sections appear and disappear
• using another user with restricted access / shared wp access => work well too

[HDinger]

Hi @cbliard

thanks for your feedback! I talked with the product team about the requirements regarding your second point:

When modifying filters, the selected menu item is still hightlighted. But I'm not sure if that's wanted or if it's a regression compared to before

This was the answer we agreed upon:

it would be logical to keep the selection and change it only if the user saves the changed view with a different name.
That way, the user still knows which view he's "on" even though they might have modified it.

So I will stick with the current behavior.

---

Regarding the first point:

When displaying the menu when clicking on the arrow next to "Work packages", multiple items are selected/highlighted, but none should be highlighted

I fixed the wrong highlighting of the "All open" query. The other query is indeed highlighted because by default, the first element is focused. However, for me, this happens only when navigating via keyboard which makes sense imho. So I tend to keep that behaviour. What do you think?

[cbliard]

Regarding the first point:

When displaying the menu when clicking on the arrow next to "Work packages", multiple items are selected/highlighted, but none should be highlighted

I fixed the wrong highlighting of the "All open" query. The other query is indeed highlighted because by default, the first element is focused. However, for me, this happens only when navigating via keyboard which makes sense imho. So I tend to keep that behaviour. What do you think?

For keyboard navigation this is fine.
It happens with mouse in a very specific scenario: click arrow, go back, click arrow, and first item is selected.
But it's very specific, it should not block merging.

Kapture.2024-07-04.at.14.52.59.webm

[cbliard]

Hi @HDinger,

I found another issue: when a query is saved, or when it is selected, then "All open" is also selected.

Kapture.2024-07-04.at.15.00.02.webm

And for the rest, it works very well.