Feature/40437 emoji reactions to work package comments #16020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0437-easy-emoji-reactions,-eg-thumbs-up-on-activity-entries
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…s not reacted as requested by @psatyal
…e/40437-emoji-reactions-to-work-package-comments
Users who do not have commenting permissions: typically the `add_work_package_notes` and anonymous users cannot add new reactions but they can view any existing reactions. Futher, the "Add reactions" button is also hidden from them. In view only state, the emoji reactions render as primer invisible buttons in disabled state. > They can respond to user input and provide feedback, but it does not trigger any actions. > See: https://primer.style/components/button#inactive The view only reactions mimic primer inactive buttons but without the muted styling and cursor change
akabiru
force-pushed
the
feature/40437-emoji-reactions-to-work-package-comments
branch
from
466a722 to
b08ed5b
Compare
…ll component refresh
Emoji Reactions should always be returned in their current state, timeslicing will yield incorrect results. At any given time, we ONLY need to know what reactions a Journal has. Further, EmojiReactions are never updated, rather created and destroyed. Retain timeslicing only for the journal render- where that is relevant to find updated journals
Journalsa are updated on last updated_at; reactions cannot rely on this as they do not "touch" the journal, so a full journal refresh would not be viable. We avoid "touching" the journal on emoji reactions update to retain concurrent user actions. E.g. If a user has a journal in edit mode, we do not want to overrite it on the next polling update- this is why it's safer to stream emoji reactions separately This reverts commit fb419dd.
akabiru
force-pushed
the
feature/40437-emoji-reactions-to-work-package-comments
branch
from
bc0ed1a to
a302f3f
Compare
Kharonus
requested changes
Oct 25, 2024
app/components/work_packages/activities_tab/journals/item_component/add_reactions.html.erb
Outdated
Show resolved
Hide resolved
akabiru
force-pushed
the
feature/40437-emoji-reactions-to-work-package-comments
branch
from
0d7d897 to
403dbd7
Compare
akabiru
force-pushed
the
feature/40437-emoji-reactions-to-work-package-comments
branch
from
403dbd7 to
88047f1
Compare
Use both hex codes to ensure red color! Tested on Safari
akabiru
force-pushed
the
feature/40437-emoji-reactions-to-work-package-comments
branch
from
96e1421 to
a6427d3
Compare
akabiru
deleted the
feature/40437-emoji-reactions-to-work-package-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/40437
What are you trying to accomplish?
Support emoji reactions to work package comments aka "journals"
Screenshots
What approach did you choose and why?
A default set of reactions is defined and rendered out as unicode points; storing the reaction strings and evaluating the corresponding unicode points allows for more flexibility for emoji modifiers. E.g. adding skin-tone support should also be evaluated at run time based on the users preference.
Merge checklist