[55181] Replace sidemenu of notification center with Rails component #16040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
force-pushed
the
implementation/55181-replace-sidemenu-of-notification-center-with-rails-component
branch
11 times, most recently
from
40a7ff0 to
9c4984c
Compare
* Show counts from actual query * Add group by project * Remove menu component * Reload menu frame when marking notification as read Co-authored-by: Oliver Günther <[email protected]>
…elf so that the center path remains unchanged in comparision to before. Otherwise, we'd have to replace all occurences of the path
…nor translation issues
…"submenu_component.sass" and harmonize the selectors
HDinger
force-pushed
the
implementation/55181-replace-sidemenu-of-notification-center-with-rails-component
branch
from
11e2f1c to
e5c7eac
Compare
oliverguenther
approved these changes
Jul 11, 2024
oliverguenther
deleted the
implementation/55181-replace-sidemenu-of-notification-center-with-rails-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the menu logic from #15840 and aims to replace the last occurence of an agular submenu with the rails Submenu component.
sidemenu.sassvssidebar.sassinto one newsubmenu.sassand harmonize the selectorshttps://community.openproject.org/projects/openproject/work_packages/55181/activity