Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#56253] Correct missing filter value in notification translation string #16252

Merged

Conversation

aaron-contreras
Copy link
Contributor

Bug work package: https://community.openproject.org/work_packages/56253

Changes "responsible" to "accountable"

Changes "responsible" to "accountable"
@cbliard cbliard force-pushed the bug/56253-missing-filter-value-in-translation-string branch from 95d2e18 to 169caae Compare August 5, 2024 10:01
@cbliard cbliard changed the base branch from dev to release/14.4 August 5, 2024 10:01
Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good. I rebased it onto release/14.4 as it does not happen anymore on dev since the primerization (it now uses only a generic message).

@cbliard cbliard merged commit 334c551 into release/14.4 Aug 5, 2024
11 checks passed
@cbliard cbliard deleted the bug/56253-missing-filter-value-in-translation-string branch August 5, 2024 12:26
ulferts referenced this pull request Sep 23, 2024
This reverts 169caae which introduces the bug in order to fix another bug. But that other bug does not longer exist as commented
https://github.com/opf/openproject/pull/16252\#pullrequestreview-2218591817
oliverguenther referenced this pull request Sep 23, 2024
This reverts 169caae which introduces the bug in order to fix another bug. But that other bug does not longer exist as commented
https://github.com/opf/openproject/pull/16252\#pullrequestreview-2218591817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants