Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#56873] Add instructions on how to develop on the BIM edition using Docker #16302

Conversation

wielinde
Copy link
Member

@wielinde wielinde commented Aug 1, 2024

What are you trying to accomplish?

  • Make it clear what steps are necessary to develop on the BIM Edition using Docker
  • Explain what the setup-bim script is doing

What approach did you choose and why?

  • Extend the Docker development setup docs
  • Add a comment to the setup-bim script

Ticket

https://community.openproject.org/work_packages/56873

@wielinde wielinde requested a review from Kharonus August 1, 2024 14:49
Copy link
Member

@apfohl apfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one small typo.

# This script installs all the required dependencies and command line tools to convert IFC files into XKT files,
# so that the BIM models can be viewed via the Xeokit BIM viewer.
#
# Run this script on your worker container with like this to enable your Docker based development setup to convert IFC\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-with

Comment on lines 58 to 59


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary white space.

@wielinde wielinde force-pushed the documentation/56873-add-instructions-on-how-to-develop-on-the-bim-edition-using-docker branch from a656827 to d3ec2ee Compare August 2, 2024 14:01
@wielinde wielinde merged commit ea7a289 into release/14.4 Aug 2, 2024
6 checks passed
@wielinde wielinde deleted the documentation/56873-add-instructions-on-how-to-develop-on-the-bim-edition-using-docker branch August 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants