-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dynamic bootstrapped components with angular elements #16431
Conversation
735ba00
to
8f4219c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell. I found some issues with the highlighting stimulus controller:
- On all WorkPackage tables the columsn are not highlighted
- With the current approach, we highlight all columns and not only those that we previously marked with the
opHighlightCol
directive. That results in columns with empty header being highlighted as well. However, that might not be such an issue. We could ask product about that.
- On the project list, there is some weird effect when hovering the hierarchy column as well as the last coumn with the "more" actions. I assume, that this closely related to the point above, as those columns were not meant to be hovered.
8f4219c
to
34ca056
Compare
@HDinger I knew this would come back to bite me. I now provided a way to disable the highlighting on a per col level and restored all the previous places |
34ca056
to
deef20e
Compare
9652dce
to
aaff7b2
Compare
aaff7b2
to
47da171
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a ticket for that: https://community.openproject.org/projects/openproject/work_packages/57329/activity |
To pave the way towards turbo, we will need to allow dynamic bootstrapping of angular elements on these visits. As we've made good experiences with Angular Elements in the past, this PR tries to get rid of all dynamically bootstrapped components in favor of angular elements.
There is one case where this is not possible: the col.opHighlight is used for table highlighting of columns, which is an attribute directive an cannot be replaced easily. This PRs replaces it with a stimulus controller instead.
https://community.openproject.org/work_packages/57269