Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#57024] Relative value macros for work package descriptions #16542

Conversation

as-op
Copy link
Contributor

@as-op as-op commented Aug 28, 2024

Ticket

https://community.openproject.org/work_packages/57024

What are you trying to accomplish?

Allow relative embedding of work package values.
e.g. in a description of work package with ID 123 use workPackageValue:assignee instead of workPackageValue:123:assignee

What approach did you choose and why?

Instead of finding the current work package in angular, I added code to the HTML pipeline, so if no ID is given AND the rendering is in context of work package (not e.g. wiki nor meeting description) => work package ID is added, so Angular does not need to do anything other than before.

Merge checklist

  • Adjusted tests
  • Adjust doumentation

@as-op as-op marked this pull request as ready for review August 29, 2024 09:50
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor remarks on the specifics of trying to match on the object, as well as the discrepancy of lookups between work packages and projects.

@as-op as-op merged commit fb4889a into dev Sep 17, 2024
13 checks passed
@as-op as-op deleted the feature/57024-macros-for-work-package-descriptions-which-are-relative-to-respective-work-packages branch September 17, 2024 10:56
top4ek added a commit to top4ek/openproject that referenced this pull request Sep 17, 2024
…_jemalloc

* 'use_jemalloc' of github.com:top4ek/openproject: (1771 commits)
  [57927] Primerise the Notification badge in the top header (opf#16742)
  add test for WorkPackageEagerLoadingWrapper text formatting; addresses opf#16542 (comment)
  chore(deps): bump md-to-pdf to v0.1.2
  [57347] Fixed NextcloudConnectionValidator specs
  Remove special mobile scrolling behavior that we introduced to collapse the adress bar on iOS Safari. It somehow conflicts with the positioning of the ActionMenu
  [57347] Restructured NextcloudConnectionValidator
  [57347] Added test for failing files query on NextcloudConnectionValidator
  [57347] Added test for unexpected files validation for Nextcloud storage
  [57347] Added unexpected content validation to NextcloudConnectionValidator
  build(deps): bump fog-aws from 3.26.0 to 3.27.0
  build(deps-dev): bump rubocop-performance from 1.21.1 to 1.22.0
  add a trailing arrow-down icon for add button in meeting module
  update locales from crowdin [ci skip]
  update locales from crowdin [ci skip]
  update locales from crowdin [ci skip]
  update locales from crowdin [ci skip]
  update locales from crowdin [ci skip]
  [57911] Improve participants side panel phrasing and spacing
  [#53620] add feature flag for buit-in apps
  Add technical notes to lookbook forms page
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants