-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#57024] Relative value macros for work package descriptions #16542
Merged
as-op
merged 9 commits into
dev
from
feature/57024-macros-for-work-package-descriptions-which-are-relative-to-respective-work-packages
Sep 17, 2024
Merged
[#57024] Relative value macros for work package descriptions #16542
as-op
merged 9 commits into
dev
from
feature/57024-macros-for-work-package-descriptions-which-are-relative-to-respective-work-packages
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions-which-are-relative-to-respective-work-packages
…tions-which-are-relative-to-respective-work-packages
oliverguenther
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor remarks on the specifics of trying to match on the object, as well as the discrepancy of lookups between work packages and projects.
…need to search; Closes #16542 (comment)
…tions-which-are-relative-to-respective-work-packages
…tions-which-are-relative-to-respective-work-packages
as-op
deleted the
feature/57024-macros-for-work-package-descriptions-which-are-relative-to-respective-work-packages
branch
September 17, 2024 10:56
top4ek
added a commit
to top4ek/openproject
that referenced
this pull request
Sep 17, 2024
…_jemalloc * 'use_jemalloc' of github.com:top4ek/openproject: (1771 commits) [57927] Primerise the Notification badge in the top header (opf#16742) add test for WorkPackageEagerLoadingWrapper text formatting; addresses opf#16542 (comment) chore(deps): bump md-to-pdf to v0.1.2 [57347] Fixed NextcloudConnectionValidator specs Remove special mobile scrolling behavior that we introduced to collapse the adress bar on iOS Safari. It somehow conflicts with the positioning of the ActionMenu [57347] Restructured NextcloudConnectionValidator [57347] Added test for failing files query on NextcloudConnectionValidator [57347] Added test for unexpected files validation for Nextcloud storage [57347] Added unexpected content validation to NextcloudConnectionValidator build(deps): bump fog-aws from 3.26.0 to 3.27.0 build(deps-dev): bump rubocop-performance from 1.21.1 to 1.22.0 add a trailing arrow-down icon for add button in meeting module update locales from crowdin [ci skip] update locales from crowdin [ci skip] update locales from crowdin [ci skip] update locales from crowdin [ci skip] update locales from crowdin [ci skip] [57911] Improve participants side panel phrasing and spacing [#53620] add feature flag for buit-in apps Add technical notes to lookbook forms page ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/57024
What are you trying to accomplish?
Allow relative embedding of work package values.
e.g. in a description of work package with ID 123 use
workPackageValue:assignee
instead ofworkPackageValue:123:assignee
What approach did you choose and why?
Instead of finding the current work package in angular, I added code to the HTML pipeline, so if no ID is given AND the rendering is in context of work package (not e.g. wiki nor meeting description) => work package ID is added, so Angular does not need to do anything other than before.
Merge checklist