[#57016] updated status API specification #16587
reviewdog [rubocop] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (107)
app/controllers/activities_controller.rb|93 col 3| Assignment Branch Condition size for determine_subprojects is too high. [<2, 24, 7> 25.08/17]
app/controllers/colors_controller.rb|46 col 5| Empty block detected.
app/controllers/concerns/accounts/current_user.rb|110 col 7| Use find_by
instead of dynamic find_by_rss_key
.
app/controllers/concerns/accounts/current_user.rb|121 col 7| Use find_by
instead of dynamic find_by_api_key
.
app/controllers/concerns/accounts/current_user.rb|127 col 12| Redundant safe navigation detected, use .
instead.
app/controllers/wiki_controller.rb|144 col 7| Use flash.now
before render
.
app/controllers/wiki_controller.rb|152 col 3| Assignment Branch Condition size for update is too high. [<6, 24, 5> 25.24/17]
app/controllers/wiki_controller.rb|170 col 7| Use flash.now
before render
.
app/controllers/wiki_controller.rb|182 col 3| Assignment Branch Condition size for rename is too high. [<6, 23, 4> 24.1/17]
app/controllers/wiki_controller.rb|193 col 9| Use flash.now
before render
.
app/controllers/wiki_controller.rb|203 col 9| Use flash.now
before render
.
app/controllers/wiki_controller.rb|222 col 19| Avoid using OpenStruct
; use Struct
, Hash
, a class or test doubles instead.
app/controllers/wiki_controller.rb|236 col 7| Use flash.now
before render
.
app/controllers/wiki_controller.rb|280 col 3| Assignment Branch Condition size for destroy is too high. [<8, 36, 12> 38.78/17]
app/controllers/wiki_controller.rb|280 col 3| Perceived complexity for destroy is too high. [11/8]
app/controllers/wiki_controller.rb|310 col 7| Move flash[:notice] = I18n.t(:notice_successful_delete)
out of the conditional.
app/controllers/wiki_controller.rb|313 col 7| Move flash[:notice] = I18n.t(:notice_successful_delete)
out of the conditional.
app/controllers/wiki_controller.rb|355 col 29| Use safe navigation (&.
) instead of checking if an object exists before calling the method.
app/helpers/application_helper.rb|45 col 50| Do not use instance variables in helpers.
app/helpers/application_helper.rb|90 col 5| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|113 col 27| Do not use Date.today
without zone. Use Time.zone.today
instead.
app/helpers/application_helper.rb|114 col 59| Do not use Date.today
without zone. Use Time.zone.today
instead.
app/helpers/application_helper.rb|125 col 3| Assignment Branch Condition size for project_nested_ul is too high. [<3, 23, 6> 23.96/17]
app/helpers/application_helper.rb|146 col 7| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|155 col 3| Assignment Branch Condition size for labeled_check_box_tags is too high. [<8, 22, 3> 23.6/17]
app/helpers/application_helper.rb|171 col 14| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|207 col 43| Do not use Time.now
without zone. Use one of Time.zone.now
, Time.current
, Time.now.in_time_zone
, Time.now.utc
, Time.now.getlocal
, Time.now.xmlschema
, Time.now.iso8601
, Time.now.jisx0301
, Time.now.rfc3339
, Time.now.httpdate
, Time.now.to_i
, Time.now.to_f
instead.
app/helpers/application_helper.rb|208 col 8| Do not use instance variables in helpers.
app/helpers/application_helper.rb|208 col 8| Use safe navigation (&.
) instead of checking if an object exists before calling the method.
app/helpers/application_helper.rb|208 col 21| Do not use instance variables in helpers.
app/helpers/application_helper.rb|211 col 35| Do not use instance variables in helpers.
app/helpers/application_helper.rb|224 col 43| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|261 col 17| Method parameter must be at least 3 characters long.
app/helpers/application_helper.rb|272 col 31| Prefer keyword arguments for arguments with a boolean default value; use blank: true
instead of blank = true
.
app/helpers/application_helper.rb|292 col 5| Useless assignment to variable - options
.
app/helpers/application_helper.rb|338 col 5| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|376 col 21| Prefer keyword arguments for arguments with a boolean default value; use checked: true
instead of checked = true
.
app/helpers/application_helper.rb|436 col 54| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|467 col 9| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|467 col 13| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|468 col 10| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|468 col 14| Prefer string interpolation to string concatenation.
app/helpers/wiki_helper.rb|77 col 33| Prefer string interpolation to string concatenation.
app/helpers/wiki_helper.rb|79 col 31| Tagging a string as html safe may be a security risk.
modules/github_integration/lib/open_project/github_integration/engine.rb|100 col 48| Use block explicitly instead of block-passing a method object.
modules/github_integration/lib/open_project/github_integration/engine.rb|102 col 48| Use block explicitly instead of block-passing a method object.
modules/github_integration/lib/open_project/github_integration/engine.rb|104 col 48| Use block explicitly instead of block-passing a method object.
spec/controllers/roles_controller_spec.rb|49 col 22| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|59 col 24| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|61 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|61 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|62 col 13| Prefer have_received
for setting message expectations. Setup Roles::CreateService
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|66 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|66 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|67 col 13| Prefer have_received
for setting message expectations. Setup service_double
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|78 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/roles_controller_spec.rb|123 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/roles_controller_spec.rb|160 col 7| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|175 col 24| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|177 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|177 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|178 col 13| Prefer have_received
for setting message expectations. Setup Roles::UpdateService
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|182 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|182 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|183 col 13| Prefer have_received
for setting message expectations. Setup service_double
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|194 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/roles_controller_spec.rb|206 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/roles_controller_spec.rb|238 col 7| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|241 col 7| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|244 col 7| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|247 col 7| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|267 col 24| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|269 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|269 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|270 col 13| Prefer have_received
for setting message expectations. Setup Roles::UpdateService
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|274 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|274 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|275 col 13| Prefer have_received
for setting message expectations. Setup service_double
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|283 col 24| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|285 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|285 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|286 col 13| Prefer have_received
for setting message expectations. Setup Roles::UpdateService
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|290 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|290 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|291 col 13| Prefer have_received
for setting message expectations. Setup service_double
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|299 col 24| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|301 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|301 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|302 col 13| Prefer have_received
for setting message expectations. Setup Roles::UpdateService
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|306 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|306 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|307 col 13| Prefer have_received
for setting message expectations. Setup service_double
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|315 col 24| Prefer using verifying doubles over normal doubles.
spec/controllers/roles_controller_spec.rb|317 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|317 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|318 col 13| Prefer have_received
for setting message expectations. Setup Roles::UpdateService
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|322 col 7| Do not use expect
in let
spec/controllers/roles_controller_spec.rb|322 col 7| Prefer allow
over expect
when configuring a response.
spec/controllers/roles_controller_spec.rb|323 col 13| Prefer have_received
for setting message expectations. Setup service_double
as a spy using allow
or instance_spy
.
spec/controllers/roles_controller_spec.rb|337 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/roles_controller_spec.rb|349 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/controllers/roles_controller_spec.rb|382 col 9| Avoid stubbing using allow_any_instance_of
.
spec/controllers/roles_controller_spec.rb|398 col 9| Avoid stubbing using allow_any_instance_of
.
spec/features/notifications/navigation_spec.rb|49 col 7| Useless assignment to variable - wp_full
.
spec/models/journable/with_historic_attributes_spec.rb|35 col 45| Do not use String#to_time
without zone. Use Time.zone.parse
instead.
spec/models/work_packages/pdf_export/work_package_to_pdf_spec.rb|31 col 1| Spec path should end with work_package/pdf_export/work_package_to_pdf*_spec.rb
.
spec/support/pages/my/password_page.rb|54 col 131| Line is too long. [172/130]