Bug/57612 work package report export fails if work package has unavailable attachments #16593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-fails-if-work-package-has-unavailable-attachments
|
Note Failing spec is unrelated. |
dombesz
approved these changes
Sep 3, 2024
dombesz
deleted the
bug/57612-work-package-report-export-fails-if-work-package-has-unavailable-attachments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
If there are faulty attachments (attachment exists in db and work_package.attachments, but work_package.attachments[0].file.local_file throws an error. So the export is stopped.
https://community.openproject.org/work_packages/57612
What are you trying to accomplish?
=> Treat it like "attachment not found", catch and log the error but don't stop the export.
Merge checklist