[#56802] Document the new component and use it to replace streamable_flash_banner #16640
Conversation
modules/meeting/app/components/meetings/update_flash_component.html.erb
Outdated
Show resolved
Hide resolved
oliverguenther
force-pushed
the
implementation/56802-document-the-new-component-and-use-it-to-replace-streamable_flash_banner
branch
3 times, most recently
from
3a36ee7 to
cde811c
Compare
oliverguenther
force-pushed
the
implementation/56802-document-the-new-component-and-use-it-to-replace-streamable_flash_banner
branch
from
cde811c to
aa30bfa
Compare
There was a problem hiding this comment.
Hi @oliverguenther,
I pushed some small docs changes that I noticed were broken. Also noticed an extra div in the base layout, potentially.
Behaviour wise it looks okay to me, but there is this issue - When you edit a meeting in a new tab that is already closed, you get the 'This meeting is not editable anymore.' flash. But this then gets replaced by the 'This page has been updated...' flash. Should that be happening? I thought we were going to do stackable flashes or whatever to allow more than one at a time.
It looks jumpy and broken sometimes imo because of the timed poll for the update flash, where in some instances the first flash is only there for a fraction of a second before being replaced.
I'm not sure what the solution is here, but maybe we could remove that first flash altogether and replace it with an instance of the second? As they are kind of doing similar things now.
oliverguenther
force-pushed
the
implementation/56802-document-the-new-component-and-use-it-to-replace-streamable_flash_banner
branch
from
35332ee to
fb741a6
Compare
|
Looks good to me now :) |
oliverguenther
deleted the
implementation/56802-document-the-new-component-and-use-it-to-replace-streamable_flash_banner
branch
https://community.openproject.org/work_packages/58142 #16640 unified the primerized flash message rendering and updated to a default overlayed flash. Hence we should remove `full: true` that is used in full width contexts which is no longer the case.
…option https://community.openproject.org/work_packages/58142 #16640 unified the primerized flash message rendering and updated to a default overlayed flash. Hence we should remove `full: true` that is used in full width contexts which is no longer the case.
Ticket
https://community.openproject.org/work_packages/56802
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist