Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#57529] Add options for sum totals calculation mode in hierarchies #16649

Merged
merged 23 commits into from
Sep 26, 2024
Merged

[#57529] Add options for sum totals calculation mode in hierarchies #16649

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
291b87b
Create setting for Calculation of % Complete hierarchy totals
aaron-contreras Sep 6, 2024
b92e9d1
Incorporate simple average mode into total % complete calculations
aaron-contreras Sep 10, 2024
53a3a72
Adjust selection of done ratio based on new rules for children
aaron-contreras Sep 16, 2024
793d758
Add radio group to progress tracking form
aaron-contreras Sep 16, 2024
06bd83f
Add feature spec for setting toggling
aaron-contreras Sep 17, 2024
503ad15
Add recalculation in job when switching to work weighted mode
aaron-contreras Sep 19, 2024
5e36ce2
Re-order radio group options according to design document
aaron-contreras Sep 20, 2024
6cbfdc8
Trigger the recalculation job when changing to work weighted mode
aaron-contreras Sep 20, 2024
2f2561c
Add in simple average calculation mode job
aaron-contreras Sep 23, 2024
1f12393
Account for status exclusion from total calculations in simple averag…
aaron-contreras Sep 24, 2024
1874fb3
Fix `status_excluded_from_totals` not existing for `WorkPackage`
cbliard Sep 25, 2024
f040848
Fix when all work packages of a hierarchy are excluded from totals
cbliard Sep 25, 2024
6d9a9c8
Removed flaky spec
cbliard Sep 25, 2024
447a6de
Fix rubocop warnings Metrics/AbcSize and Metrics/PerceivedComplexity
cbliard Sep 25, 2024
0f9be1b
Add a test when all hierarchy is excluded from totals
cbliard Sep 25, 2024
a574b2f
Add failing spec about handling simple average mode in a job
cbliard Sep 25, 2024
3f97171
Use work_package_hierarchies to create depth table
cbliard Sep 25, 2024
3250f51
Compute total % complete according to mode in update status job
cbliard Sep 25, 2024
946b57d
Merge branch 'dev' into implementation/57529-options-for-total-calcul…
aaron-contreras Sep 25, 2024
0edb100
Add extra spec specifically accounting for excluded statuses
aaron-contreras Sep 25, 2024
5b1dbb4
Test for unset total values
aaron-contreras Sep 25, 2024
95cda6d
Remove unnecessary update
aaron-contreras Sep 25, 2024
de86221
Extract common operations to sql_commands
aaron-contreras Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/workers/work_packages/progress/sql_commands.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ def update_totals
if Setting.total_percent_complete_mode == "work_weighted_average"
update_total_percent_complete_in_work_weighted_average_mode
elsif Setting.total_percent_complete_mode == "simple_average"
update_total_percent_complete_in_work_weighted_average_mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

update_total_percent_complete_in_simple_average_mode
end
end
Expand Down