Ambiguous button_save_as translation fix #16692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Good catch, thanks.
Please note that the translations within the crowdin/ folders will be lost on the next translation update. They are being generated from crowdin (https://www.openproject.org/docs/development/translate-openproject/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Remove ambiguous translation in Reporting module. This leads us to different translations in production and development modes at least.
Screenshots
There're two translations of button_save_as menu item. Here and here.
What approach did you choose and why?
Use new translation key button_save_report_as inside reporting module leaving global button_save_as untouched.