Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup filter list controller #16696

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Cleanup filter list controller #16696

merged 3 commits into from
Sep 11, 2024

Conversation

toy
Copy link
Contributor

@toy toy commented Sep 10, 2024

What are you trying to accomplish?

A bit of cleanup, mostly remove repetition of 'd-none', also use hasNoResultsTextTarget so there are no warning about using resultsTextTarget when it does not exist.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy toy requested a review from HDinger September 10, 2024 18:04
HDinger
HDinger approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍 🥳

@HDinger HDinger merged commit 0c40783 into dev Sep 11, 2024
8 checks passed
@HDinger HDinger deleted the cleanup-FilterListController branch September 11, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDinger HDinger HDinger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toy @HDinger