[#55021] Free choice of columns in exports #16705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, if you want to export these columns, you must explicitly select these in the view configuration before exporting. Your export will always reflect the columns that you see in the web view.
EinLama
force-pushed
the
feature/55021-free-choice-of-columns-in-exports
branch
from
625fc1c to
a8d365e
Compare
Both id and identifier are simple strings. No need no mark them as html_safe.
EinLama
force-pushed
the
feature/55021-free-choice-of-columns-in-exports
branch
from
76de79e to
3c2a48c
Compare
oliverguenther
deleted the
feature/55021-free-choice-of-columns-in-exports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention
This is my first real PR for OpenProject. Please be extra thorough when reviewing this. I took care when assembling this PR, but I probably forgot something 😉
Ticket
https://community.openproject.org/wp/55021
What are you trying to accomplish?
In the project list, you can now select and switch the order of the ID and identifier columns.
Previously, these columns were not visible, but they were always part of the CSV and XLS export. Now, those columns are only part of the export when they have been explicitly configured in the view.
In other words: the ID and identifier columns now behave like all other columns.
Screenshots
CSV export sample (with id and identifier not showing in the view):
What approach did you choose and why?
I decided to hide the id and identifier columns by default. Since they have not been part of the default project list view until now I figured that they are not important to most users. If needed, they can now be configured to show up.
The columns were part of the export by default, but from my understanding, users visit this page more often than they export it. Hence, omitting these columns by default is the best choice. Users relying on the columns being present in an export might run into issues, though ☝🏻 We should include a notice in the release notes.
Please note that some columns are only visible for admins. I did not see a reason to hide id and identifier here, so I added them for everyone to see.
Translations for the "new columns" worked out of the box 👍🏻
Merge checklist