[#57671] Improve display of work package and agenda titles in meetings #16791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmir
force-pushed
the
feature/57671-improve-display-of-work-package-and-agenda-titles-in-meetings
branch
3 times, most recently
from
a8e6184 to
201183f
Compare
mrmir
force-pushed
the
feature/57671-improve-display-of-work-package-and-agenda-titles-in-meetings
branch
from
201183f to
6c06bb2
Compare
HDinger
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Hi @mrmir
I have some minor remarks
- In the visuals, the type and status are highlighted with their respective colours.
- The position of the user avatar differs between WorkPackage agenda items and normal agenda items:
- The three dots are not correctly aligned compared to the user name next to it
modules/meeting/app/components/meeting_agenda_items/item_component/show_component.sass
Outdated
Show resolved
Hide resolved
|
Thanks @HDinger, The spec has been updated, so please take another look |
HDinger
deleted the
feature/57671-improve-display-of-work-package-and-agenda-titles-in-meetings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/57671
What are you trying to accomplish?
This PR is to display the full titles of agenda items and work packages in a meeting, and modify the layout to look better with these full titles as well.
What approach did you choose and why?
This PR consists of changes to the grid layout for the individual meeting agenda items to better suit the new layout. The work package type and status are now displayed even in the mobile layout. An older issue with the presenter moving out of the right margin has also been dealt with here.
Merge checklist