Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#57814] add detail page for hierarchy custom fields #16842

Merged
merged 3 commits into from
Oct 1, 2024
Merged

[#57814] add detail page for hierarchy custom fields #16842

merged 3 commits into from
Oct 1, 2024

Conversation

Kharonus
Copy link
Member

@Kharonus Kharonus commented Sep 27, 2024 •
edited
Loading

Ticket

OP#57814

What are you trying to accomplish?

  • editing of details of custom field of type hierarchy is possible
  • form is written with primer components
    • spacing is off, but this is known for primer forms
  • existing custom fields of type hierarchy are not usable yet

Screenshots

image

@Kharonus Kharonus self-assigned this Sep 27, 2024
@Kharonus
[#57814] add detail page for hierarchy custom fields
91db17b 
- https://community.openproject.org/work_packages/57814
- add switch to display primer detail page only for custom
  fields of type hierarchy
- add all relevant form elements
- remark: spacing is not correct yet and will be fixed for all primer
  forms later
@Kharonus
[#57814] exclude existing hierarchy fields from config lists
e0097af 
- hide hierarchy custom fields when configuring work package types
- hide hierarchy custom fields when enabling custom fields for projects
@Kharonus Kharonus force-pushed the implementation/57814-add-custom-field-detail-page-for-hierarchy-custom-fields branch from 9abe022 to e0097af Compare September 30, 2024 11:32
@Kharonus Kharonus marked this pull request as ready for review September 30, 2024 11:32
@Kharonus Kharonus requested review from akabiru and apfohl October 1, 2024 09:44
akabiru
akabiru approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 Just a few non-blocking remarks

app/views/custom_fields/edit.html.erb Outdated Show resolved Hide resolved
app/components/custom_fields/details_component.html.erb Show resolved Hide resolved
app/forms/custom_fields/details_form.rb Show resolved Hide resolved
app/forms/custom_fields/details_form.rb Show resolved Hide resolved
@Kharonus
Copy link
Member Author

Kharonus commented Oct 1, 2024

I took those three topics to the UX team:

  • dismissable banner
  • grouping of inputs
  • caption for multi_value

Merging this PR, but the answers of it will eventually influence the upcoming changes.

@Kharonus Kharonus merged commit 05a30db into dev Oct 1, 2024
11 checks passed
@Kharonus Kharonus deleted the implementation/57814-add-custom-field-detail-page-for-hierarchy-custom-fields branch October 1, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akabiru akabiru akabiru approved these changes

@apfohl apfohl apfohl approved these changes

Assignees

@Kharonus Kharonus

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kharonus @apfohl @akabiru