Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#57854] Primerised Meeting index pages #16860

Merged
merged 10 commits into from
Nov 11, 2024
Merged

[#57854] Primerised Meeting index pages #16860

merged 10 commits into from
Nov 11, 2024

Conversation

mrmir
Copy link
Contributor

@mrmir mrmir commented Sep 30, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/57854

What are you trying to accomplish?

  • Primerize the meetings index page
  • Add a new creation and copy flow via dialog forms

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch 2 times, most recently from d9ebd1d to e2704fd Compare October 11, 2024 14:38
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch 5 times, most recently from a753849 to c25d05d Compare October 30, 2024 16:32
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch from c25d05d to bf5c92a Compare November 7, 2024 10:17
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch from bf5c92a to 1811860 Compare November 7, 2024 10:23
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch 2 times, most recently from 31460e4 to a6e29ee Compare November 7, 2024 15:38
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch from da9b1fa to f9a1fac Compare November 8, 2024 09:35
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch 4 times, most recently from c06aa85 to abcbecc Compare November 8, 2024 16:47
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch from abcbecc to 754d796 Compare November 8, 2024 17:26
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch from c795755 to e44f5d1 Compare November 10, 2024 23:56
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch from e44f5d1 to 5593d7d Compare November 11, 2024 08:23
@oliverguenther oliverguenther marked this pull request as ready for review November 11, 2024 08:34
@mrmir mrmir added the feature label Nov 11, 2024
oliverguenther
oliverguenther requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, there's a few keys that need to be translated

modules/meeting/app/forms/meeting/email_participants.rb Outdated Show resolved Hide resolved
modules/meeting/app/forms/meeting/copy_attachments.rb Outdated Show resolved Hide resolved
modules/meeting/app/forms/meeting/copy_items.rb Outdated Show resolved Hide resolved
modules/meeting/app/forms/meeting/copy_participants.rb Outdated Show resolved Hide resolved
@mrmir mrmir force-pushed the feature/57854-primerised-meeting-index-pages branch from 5593d7d to ed5dce9 Compare November 11, 2024 09:51
@mrmir mrmir requested a review from oliverguenther November 11, 2024 09:51
@oliverguenther oliverguenther merged commit 88859fe into dev Nov 11, 2024
11 checks passed
@oliverguenther oliverguenther deleted the feature/57854-primerised-meeting-index-pages branch November 11, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmir @oliverguenther