[#56917] Increase contrast of skip button in onboarding tour #16862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
HDinger
approved these changes
Oct 1, 2024
HDinger
deleted the
bug/56917-transparent-button-of-onboarding-tour-hard-to-see
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/56917
What are you trying to accomplish?
Increase the contrast of the skip button against its background
Screenshots
Before
After (light-mode)
After (dark-mode)
What approach did you choose and why?
Renamed the
btn-trasparentclass forenjoyhintbuttons tobtn-secondaryand added some background and foreground combinations that pass a 3:1 contrast ratio check.Merge checklist