Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#57815] add item page for hierarchies #16868

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[#57815] add item page for hierarchies #16868

merged 1 commit into from
Oct 2, 2024

Conversation

Kharonus
Copy link
Member

@Kharonus Kharonus commented Oct 1, 2024 •
edited
Loading

Ticket

OP#57815

What are you trying to accomplish?

  • add a new tab named "Items" to custom fields of type hierarchy

What approach did you choose and why?

  • add pure blankslate component to be shown
  • add new route /custom_fields/:id/items
  • add tab Items under condition, that custom field is of type hierarchy
  • add item button not functional, creation of items will be in a later PR

Screenshots

image

@Kharonus Kharonus requested a review from a team October 1, 2024 09:27
@Kharonus Kharonus self-assigned this Oct 1, 2024
@Kharonus Kharonus removed the request for review from a team October 1, 2024 09:45
@Kharonus
[#57815] add item page for hierarchies
dc667cc 
- https://community.openproject.org/work_packages/57815
- add new tab only for hierarchy custom fields
- show blank slate and non-functional button
@Kharonus Kharonus force-pushed the implementation/57815-add-custom-field-value-page-for-hierarchy-custom-fields branch from 933fe39 to dc667cc Compare October 1, 2024 12:42
@Kharonus Kharonus requested review from akabiru and apfohl October 1, 2024 12:42
@Kharonus Kharonus marked this pull request as ready for review October 1, 2024 12:43
akabiru
akabiru reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, although missing (feature) tests 🟠 any plans to add those?

app/components/admin/custom_fields/edit_form_header_component.html.erb Show resolved Hide resolved
app/components/admin/custom_fields/hierarchy/item_component.html.erb Show resolved Hide resolved
@Kharonus
Copy link
Member Author

Kharonus commented Oct 2, 2024

Feature tests are planned, once there are more use cases implemented. IMHO we need at least:

  • custom field creation ✅
  • custom field editing (details) ✅
  • custom field deletion ✅
  • custom field editing (inserting items) ❌

additional use cases are (which then can be used to amend the feature spec):

  • insert items under items
  • editing items
  • moving items
  • deleting items
  • soft deleting items

So, from this list, I'm missing one use case to write a sensible feature spec. ;)

@Kharonus Kharonus merged commit ada70fc into dev Oct 2, 2024
11 checks passed
@Kharonus Kharonus deleted the implementation/57815-add-custom-field-value-page-for-hierarchy-custom-fields branch October 2, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akabiru akabiru akabiru left review comments

@apfohl apfohl apfohl approved these changes

Assignees

@Kharonus Kharonus

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kharonus @apfohl @akabiru