Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#58143] Add the new role and apply defaults #16881

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Oct 2, 2024

Ticket

Both tickets are addressed in this PR:

What are you trying to accomplish?

Add a new global permission "View users' email addresses" and add a new global builtin role "Standard global role" in order to have a place for assigning roles for every user in the system.
Enable the "View users' email addresses" on this new role by default.

Enforce displaying the user's email and allow searching users by email addresses via the API based on the "View users' email addresses" permission.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dombesz dombesz force-pushed the implementation/58143-add-the-new-role-and-apply-defaults branch 7 times, most recently from aaa28a2 to 1501bb1 Compare October 8, 2024 09:40
@dombesz dombesz force-pushed the implementation/58143-add-the-new-role-and-apply-defaults branch from 1501bb1 to 0dbc52f Compare October 8, 2024 09:42
@dombesz dombesz marked this pull request as ready for review October 8, 2024 09:43
@opf opf deleted a comment from github-actions bot Oct 8, 2024
@aaron-contreras aaron-contreras self-requested a review October 8, 2024 15:14
@aaron-contreras aaron-contreras self-assigned this Oct 8, 2024
Copy link
Contributor

@aaron-contreras aaron-contreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion! Perhaps there's a reason not to do it this way but I'm curious about it.

@dombesz dombesz merged commit 0ecfb02 into dev Oct 11, 2024
14 checks passed
@dombesz dombesz deleted the implementation/58143-add-the-new-role-and-apply-defaults branch October 11, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants