[53809] Update PageHeaders & SubHeaders in the (rails) global index pages (fix issues)

[bsatarnejad]

Ticket

https://community.openproject.org/projects/design-system/work_packages/53809/activity

What are you trying to accomplish?

Fix remaining issues from previous PR: Breadcrumbs correction in Home, Meetings, Time and costs pages, use Primer button for adding a new board, calendar, team planner.

Screenshots

Before:

After:

Before:

After:

Before:

After:

Before:

After:

What approach did you choose and why?

Use Primer button for creating a new board, calendar, team planner and fix breadcrumbs.

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[HDinger]

Hi @bsatarnejad

• Please restore the addButtonComponent and use a Primer Button inside. Currently you have a lot of duplicated code, see my comment in code.

Further, I have some minor remarks:

• On the project list, the name of the Organisation is missing which is incosnistent to the rest of the application

• On the notification center, it still says "Home" instead of the organisation name

• In all affected project pages, the breadcrumb now says "Organisation name / Project name / module name" which is inconsistent to the pages that we already replaced which only say "Project name / module name"

• I think the "Export" button in the Time&Costs module should be part of the PageHeader and not the SubHeader. Please double check with the product team.

• In the meetings module, the header is not reflecting the selection in the sidemenu

[HDinger]

Why didn't you just change this component to use a Primer Button? Now, you duplicated a lot of code in the individual modules. The SubHeader can deal with custom components on the right side, so that should not be a problem.

[HDinger]

I cherry-picked most of the commits to #16934 except for those that affect the AddButtonComponent. I think we misunderstood each other here. 🙈 I changed it in the other PR, maybe we can have a chat about what I had in mind.