Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation/58105 item persistence service #16884

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Implementation/58105 item persistence service #16884

merged 5 commits into from
Oct 8, 2024

Conversation

apfohl
Copy link
Member

@apfohl apfohl commented Oct 2, 2024 •
edited by Kharonus
Loading

Ticket

OP#58105

What are you trying to accomplish?

PART 1

Implement a service capable of manipulation a hierarchy of items for the custom field of type hierarchy.

  • initialize
  • generate_root
  • insert_item

What approach did you choose and why?

  • Dry::Validation contracts for input checking
  • Dry::Monads for error handling

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@apfohl apfohl requested a review from Kharonus October 2, 2024 12:20
Kharonus
Kharonus requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@Kharonus Kharonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should take care of some small bobs and bits, wdyt?

spec/contracts/custom_fields/hierarchy/insert_item_contract_spec.rb Show resolved Hide resolved
app/contracts/custom_fields/hierarchy/insert_item_contract.rb Show resolved Hide resolved
app/contracts/custom_fields/hierarchy/generate_root_contract.rb Show resolved Hide resolved
app/contracts/custom_fields/hierarchy/service_initialization_contract.rb Outdated Show resolved Hide resolved
spec/services/custom_fields/hierarchy/hierarchical_item_service_spec.rb Outdated Show resolved Hide resolved
@apfohl apfohl requested a review from Kharonus October 8, 2024 08:58
@apfohl apfohl force-pushed the implementation/58105-item-persistence-service branch from 05d25a0 to c20dc55 Compare October 8, 2024 09:14
@apfohl apfohl requested a review from Kharonus October 8, 2024 11:51
Kharonus
Kharonus approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Kharonus Kharonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice!

@apfohl apfohl merged commit a91efed into dev Oct 8, 2024
11 checks passed
@apfohl apfohl deleted the implementation/58105-item-persistence-service branch October 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kharonus Kharonus Kharonus approved these changes

Assignees
No one assigned
Labels
needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfohl @Kharonus