[58242] Generalize the wp preview modal to be reused for users #16885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
force-pushed
the
feature/55581-create-generic-hover-card
branch
2 times, most recently
from
f9b1e29 to
301641a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
frontend/src/app/shared/components/modals/preview-modal/hover-card-modal/hover-card.modal.ts
Fixed
Show fixed
Hide fixed
HDinger
force-pushed
the
feature/55581-create-generic-hover-card
branch
3 times, most recently
from
fdcf716 to
14637bb
Compare
…Frame inside to be more flexible about the content
HDinger
force-pushed
the
feature/55581-create-generic-hover-card
branch
from
14637bb to
fb0b29b
Compare
HDinger
force-pushed
the
feature/55581-create-generic-hover-card
branch
from
db54d4e to
28abeba
Compare
oliverguenther
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Generally, looks very good already. I noticed that when you have the card pop up at the top due to spacing constraints, there appears to be a shift in position. I also saw the hover card not appearing (first try in the video), it happens when you quickly hover and remove hover. Probably not a big issue, but we could set a timeout before closing the hover card?
Kapture.2024-10-08.at.13.44.23.webm
…ard-pattern [58267] Document hover card pattern
oliverguenther
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/design-system/work_packages/58242/activity
https://community.openproject.org/projects/design-system/work_packages/58267/activity
What are you trying to accomplish?
This is a preconditional work to show a little popover over users (which we currently only have for WorkPackages)
WpPreviewto be generalized and rename itHoverCardHighlightedTypeComponentfor WorkPackagesStatusButtonComponentfor WorkPackagesScreenshots
Merge checklist