Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing custom fields in a project webhook #16912

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Oct 7, 2024

Ticket

https://community.openproject.org/work_packages/58287

What are you trying to accomplish?

Ensure custom field values are shown for webhook requests

Screenshots

What approach did you choose and why?

The getter was only called outside the user system block, which caused the custom fields to not be visible

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dombesz
Copy link
Contributor

dombesz commented Oct 7, 2024

Nice catch!👍
I believe the target branch needs to be changed before merging.

@oliverguenther oliverguenther changed the base branch from dev to release/14.6 October 8, 2024 05:53
The getter was only called outside the user system block,
which caused the custom fields to not be visible
@oliverguenther oliverguenther force-pushed the fix/custom-field-webhook branch from fd37046 to 98959e8 Compare October 8, 2024 05:53
@oliverguenther oliverguenther merged commit ed73e01 into release/14.6 Oct 8, 2024
11 checks passed
@oliverguenther oliverguenther deleted the fix/custom-field-webhook branch October 8, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants