Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#58144] Show email on the UI for users with permission #16919

Merged
merged 30 commits into from
Oct 28, 2024
Merged

[#58144] Show email on the UI for users with permission #16919

merged 30 commits into from
Oct 28, 2024

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Oct 8, 2024 •
edited by EinLama
Loading

Ticket

https://community.openproject.org/work_packages/58144

What are you trying to accomplish?

Remove hide_mail flag and replace with :view_user_email permission checks.
Display email addresses in the user autocompleters.

ToDo

  • Remove user hide_mail setting.
  • Replace existing user email preferences with a view_user_email permission check.
  • Update autocompleters to display emails based on the view_user_email permission check.
    • Select project members
    • Share work packages
    • Work Package assignee, accountable, watchers
    • Work Package filter user autocompleters
    • Share project lists
    • Select group members
    • Invite user modal (+ button on the top bar)

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Base automatically changed from implementation/58143-add-the-new-role-and-apply-defaults to dev October 11, 2024 10:02
@dombesz dombesz force-pushed the implementation/58144-show-email-on-the-ui-for-users-with-permission branch from 6a3f436 to 8e09dfc Compare October 11, 2024 10:14
EinLama
EinLama reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@EinLama EinLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently looking into this PR to understand what it does. Just leaving some comments here as note to myself :)

@EinLama EinLama force-pushed the implementation/58144-show-email-on-the-ui-for-users-with-permission branch from f9d158f to cb1330c Compare October 22, 2024 08:12
dombesz and others added 26 commits October 28, 2024 09:09
@dombesz @EinLama
[#58144] Show email on the UI for users with permission
84505e2 
https://community.openproject.org/work_packages/58144
Remove hide_mail flag and replace with :view_user_email permission checks
@dombesz @EinLama
Add migration spec
c9cd578
@dombesz @EinLama
Fix specs
e065e1a
@dombesz @EinLama
Remove hideMail flag from the frontend and documentation
3c83166
@dombesz @EinLama
Fix specs
58bf751
@dombesz @EinLama
Do not allow searching for email without view email permission
8379c56
@dombesz @EinLama
Fix specs
502624c
@dombesz @EinLama
Enable email signaling and display emails in user autocompleters.
02d0923
@HDinger @EinLama
Do not truncate the whole user option completely but rather the part …
b569979 
…that is not visible any more (e.g. inside the WP table)
@dombesz @EinLama
Simplify the autocompleter layout, plus fix truncation issue on small…
1a8112b 
… desktop size.
@dombesz @EinLama
Apply autocompleter emails to the invite user modal.
c20ca0e
@dombesz @EinLama
Add email to user related autocomplete filters
c220d20
@dombesz @EinLama
Make the autocompleter aligned on the team planner and the assignee b…
e1cbe66 
…oard
@dombesz @EinLama
Fix specs
0433dab
@dombesz @EinLama
Add user invitation, work package share, user signal rendering specs
b58723e
@EinLama
Changes from dev
ef500a7
@EinLama
fix typo, add mini spec
1387fd3
@EinLama
fix specs
7a42399
@EinLama
first assignee spec
a4a7ee1
@EinLama
set accountable spec
3d60c23
@EinLama
use existing helpers when available
0d9d252
@EinLama
minor refactors
4041f86
@EinLama
watcher specs
de57eee
@EinLama
refactor work package specs to also use global roles
ad66d36
@EinLama
Move autocomplete helper to the proper place
0f0e361
@EinLama
filter search spec
b63e7d7
@EinLama EinLama force-pushed the implementation/58144-show-email-on-the-ui-for-users-with-permission branch from 5217ec7 to d758437 Compare October 28, 2024 08:10
@EinLama EinLama marked this pull request as ready for review October 28, 2024 08:11
@EinLama EinLama self-assigned this Oct 28, 2024
@EinLama EinLama merged commit 36bb0fa into dev Oct 28, 2024
17 checks passed
@EinLama EinLama deleted the implementation/58144-show-email-on-the-ui-for-users-with-permission branch October 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EinLama EinLama EinLama left review comments

Assignees

@EinLama EinLama

Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dombesz @EinLama @HDinger