Update OIDC configuration UI #16935
Merged
Update OIDC configuration UI #16935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba1ash
force-pushed
the
feature/57677-oidc-ui
branch
10 times, most recently
from
4082d8e to
7738bb7
Compare
oliverguenther
force-pushed
the
feature/57677-oidc-ui
branch
3 times, most recently
from
1af6673 to
47d66f7
Compare
oliverguenther
force-pushed
the
feature/57677-oidc-ui
branch
4 times, most recently
from
2abcc93 to
7d89e79
Compare
oliverguenther
force-pushed
the
feature/57677-oidc-ui
branch
5 times, most recently
from
8764daa to
8b4c7d8
Compare
machisuji
reviewed
Oct 18, 2024
| <fieldset class="form--fieldset"> | ||
| <legend class="form--fieldset-legend"><%= I18n.t(:'settings.authentication.single_sign_on') %></legend> | ||
| <div class="form--field"> | ||
| <% providers = AuthProvider |
There was a problem hiding this comment.
These 6 lines should really go into a helper and not live in a template.
machisuji
reviewed
Oct 18, 2024
| options | ||
| .select { |key, _| Saml::Provider.stored_attributes[:options].include?(key.to_s) } | ||
| .each do |key, value| | ||
| model.public_send(:"#{key}=", value) |
There was a problem hiding this comment.
The only thing necessary for the triumph of evil is for good men to do nothing.
I have to at least denounce this indentation for the record.
It is not relevant for the configured? check
otherwise they will appear incomplete, even though they are complete
It is defined in the omnaiuth gem already (however with different bits)
oliverguenther
force-pushed
the
feature/57677-oidc-ui
branch
from
7e76f60 to
6ac6af4
Compare
machisuji
reviewed
Oct 21, 2024
| require "spec_helper" | ||
|
|
||
| require Rails.root.join("modules/openid_connect/db/migrate/20240829140616_migrate_oidc_settings_to_providers.rb") | ||
| RSpec.describe MigrateOidcSettingsToProviders, type: :model do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/57677
https://community.openproject.org/wp/58437
https://community.openproject.org/wp/58451
Screenshots
Sign in screen.
OIDC providers table.
Custom form
Peek.2024-10-14.15-45.mp4
Google and Microsoft Entra form
Peek.2024-10-14.16-33.mp4
What approach did you choose and why?
Create new UI to configure OIDC providers.
TODO:
Setting.plugin_openproject_openid_connect.modules/openid_connect/app/seeders/env_data/openid_connect/provider_seeder.rb. Accessible throughSetting.seed_openid_connect_provider. Env alias is:OPENPROJECT_OPENID__CONNECTauth_providerstable. UseOpenIDConnect::Providermodel to manipulate it. This model is used to work with three types of OIDC providers: Google, Entra, Custom.OpenIDConnect::Provider#oidc_provideris used for distinguishing between them.modules/openid_connect/app/services/openid_connect/providers/update_service.rb. The request is done for all three types, but UI allows to fill it in only for Custom case. For Google the URL is static. For Microsoft it is derived from tenant.See https://www.openproject.org/docs/installation-and-operations/misc/custom-openid-connect-providers/#attribute-mapping for env variable usage example.
It is used here, for example: https://github.com/opf/openproject/blob/dev/app/services/authentication/omniauth_service.rb#L263.
Rough plan:
OpenIDConnect::Providermodules/openid_connect/app/services/openid_connect/sync_service.rbwhich is used in the migration and seeder.OpenIDConnect::Provider#to_hand make sure it is available in appropriate OmniAuth::OpenIDConnect::Provider instance returned byOpenProject::OpenIDConnect.providers.