Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the form that was removed in 14.4 #16961

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Restore the form that was removed in 14.4 #16961

merged 2 commits into from
Oct 16, 2024

Conversation

mereghost
Copy link
Contributor

This restores the save button for OP#58400

@mereghost mereghost self-assigned this Oct 15, 2024
@mereghost mereghost requested a review from a team October 15, 2024 16:25
HDinger
HDinger requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original commit moved the PageHeader and the form inside of the partial. So simply restoring the form here, will result in doubled content.

Bildschirmfoto 2024-10-16 um 08 26 45

I will push a change in a bit.

@mereghost mereghost requested a review from HDinger October 16, 2024 08:10
@mereghost
Copy link
Contributor Author

Thanks @HDinger ! It works with the DB plugin. =)

@mereghost mereghost merged commit 28446a4 into release/14.6 Oct 16, 2024
11 checks passed
@mereghost mereghost deleted the bugfix/re-wrap-plugin-settings-in-form branch October 16, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kharonus Kharonus Kharonus approved these changes

@HDinger HDinger HDinger approved these changes

Assignees

@mereghost mereghost

Labels
needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mereghost @HDinger @Kharonus