[#57817] add deletion action to item action menu #16972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://community.openproject.org/work_packages/57817 - added dialog component to safe guard item deletion - added controller actions and routes to open dialog and delete item
mereghost
requested changes
Oct 17, 2024
app/controllers/admin/custom_fields/hierarchy/items_controller.rb
Outdated
Show resolved
Hide resolved
brunopagno
approved these changes
Oct 17, 2024
app/components/admin/custom_fields/hierarchy/item_component.html.erb
Outdated
Show resolved
Hide resolved
- updated action menu item construction method
brunopagno
approved these changes
Oct 17, 2024
mereghost
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#57817
What are you trying to accomplish?
What approach did you choose and why?