Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CostType redirect to index after deletion. #16974

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix CostType redirect to index after deletion. #16974

merged 1 commit into from
Oct 16, 2024

Conversation

top4ek
Copy link
Contributor

@top4ek top4ek commented Oct 16, 2024 •
edited by ulferts
Loading

What are you trying to accomplish?

Fix report deletion redirect.

  1. Go to /cost_reports
  2. Select report or save new one. Browser is located to /cost_reports/:id
  3. Delete report.
  4. Browser is still located /cost_reports/:id
  5. Click on Update button leads to 500 error as @query is not populated

What approach did you choose and why?

Nullify ID after destroy. Actually, i'm not sure if it correct way to fix it as I still don't get the way controller works completely :)

Work Package

https://community.openproject.org/wp/58441

@top4ek top4ek changed the title Fix redirect to index Fix CostType redirect to index after deletion. Oct 16, 2024
@top4ek top4ek marked this pull request as ready for review October 16, 2024 13:39
ulferts
ulferts approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much obliged @top4ek

@ulferts ulferts merged commit 0c7c61a into opf:dev Oct 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulferts ulferts ulferts approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@top4ek @ulferts