Feature/57778 remove the project details widget from project overview #17042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
force-pushed
the
feature/57778-remove-the-project-details-widget-from-project-overview
branch
2 times, most recently
from
fa43893 to
a9027d2
Compare
cbliard
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
It works as expected.
Meanwhile I found the following remaining pieces:
- i18n key
en.js.project.details_activitystill inconfig/locales/js-en.ymlfile - Development concept: Inline editing still referencing
ProjectDetailsComponentindocs/development/concepts/inline-editing/README.md - The doc in
docs/system-admin-guide/attribute-help-texts/README.mdneeds to be updated: in the "Projects" section it currently says "The Attribute help texts for projects will be displayed in the Project details widget in the project overview and in the project settings" which is incorrect. Screenshots need to be updated as well. - The doc in
docs/user-guide/project-overview/README.mdneeds to be updated to remove the reference to "Project details widget" - In
modules/grids/lib/grids/configuration/in_project_base_registration.rbon line 7, there is a reference to "project_details" widget. Not sure how useful it is given that it still works.
I'll let you merge it when you see fit.
ulferts
force-pushed
the
feature/57778-remove-the-project-details-widget-from-project-overview
branch
from
a9027d2 to
594a648
Compare
|
@cbliard thanks for the thorough review/detective work. I am glad that you spotted all those places I overlooked. |
ulferts
deleted the
feature/57778-remove-the-project-details-widget-from-project-overview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/57778
What are you trying to accomplish?
The 'project_details' widget is removed. A migration will remove it from all the existing project overviews. That migration will not attempt to close the gap that might remain in the overview page as it is unclear what to do automatically. So the user will have to move/resize widgets.
Merge checklist