[#58520] add an endpoint to fetch the hierarchy #17075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kharonus
force-pushed
the
implementation/58520-api-add-endpoint-for-fetching-the-tree
branch
from
5e1db5c to
d6ac7fb
Compare
brunopagno
reviewed
Oct 29, 2024
docs/api/apiv3/components/examples/hierarchy_item_collection_filtered_response.yml
Outdated
Show resolved
Hide resolved
docs/api/apiv3/components/examples/hierarchy_item_collection_response.yml
Show resolved
Hide resolved
apfohl
suggested changes
Nov 5, 2024
apfohl
approved these changes
Nov 5, 2024
- https://community.openproject.org/work_packages/58520 - add API specification about the endpoint
- implement hashed subtree retrieval in persistence layer - implement flattening of hashed subtree in applicaiton layer - added api spec for GET /custom_field_items/:id route - added self link, parent and children to http response - added api for single hierarchy item route - write unit tests for hashed_subtree in HierarchicalItemService - add parameter validation to api endpoint
Kharonus
force-pushed
the
implementation/58520-api-add-endpoint-for-fetching-the-tree
branch
from
cb062fe to
a8c0ec5
Compare
mereghost
approved these changes
Nov 5, 2024
Kharonus
deleted the
implementation/58520-api-add-endpoint-for-fetching-the-tree
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#58520
What are you trying to accomplish?
What approach did you choose and why?
Hint for review
This review is easily separable into
a) the API specification files, located under
/docsb) the code, in
/app,/lib/api, and/specthose could be separate PRs, but sadly I have those changes on the same commits.