Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation/58521 api add endpoint for fetching a branch #17125

Merged

Conversation

apfohl
Copy link
Member

@apfohl apfohl commented Nov 6, 2024

Ticket

https://community.openproject.org/projects/document-workflows-stream/work_packages/58521/

What are you trying to accomplish?

Added API endpoint for fetching the branch of a custom field item.

@apfohl apfohl requested review from a team and removed request for a team November 6, 2024 10:22
@apfohl apfohl marked this pull request as draft November 6, 2024 10:24
@apfohl apfohl force-pushed the implementation/58521-api-add-endpoint-for-fetching-a-branch branch 2 times, most recently from 07d5807 to 4d882fa Compare November 6, 2024 12:46
@apfohl apfohl marked this pull request as ready for review November 6, 2024 12:46
@apfohl apfohl requested a review from a team November 6, 2024 12:46
Copy link
Member

@Kharonus Kharonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the API spec needs a small improvement, then it's green from my side.

- Added OpenAPI spec for new endpoint
- Added new API endpoint: /api/v3/custom_field_items/{id}/branch
- Used HierarchicalItemService to retrieve branch for item
@apfohl apfohl force-pushed the implementation/58521-api-add-endpoint-for-fetching-a-branch branch from 4d882fa to a8965fe Compare November 6, 2024 14:02
@apfohl apfohl requested a review from Kharonus November 6, 2024 14:03
@apfohl apfohl merged commit b28b994 into dev Nov 6, 2024
13 checks passed
@apfohl apfohl deleted the implementation/58521-api-add-endpoint-for-fetching-a-branch branch November 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants