[58734] Extract work package info line into a Primer component and document it #17234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes sure, I'll do that 👍 |
bsatarnejad
changed the base branch from
dev
to
implementation/58345-re-design-relations-tab-according-to-figma-mockups
bsatarnejad
changed the base branch from
implementation/58345-re-design-relations-tab-according-to-figma-mockups
to
dev
bsatarnejad
force-pushed
the
58734-extract-work-package-info-line-into-a-primer-component-and-document-it
branch
2 times, most recently
from
5dceab8 to
b0f754e
Compare
bsatarnejad
changed the base branch from
dev
to
implementation/58345-re-design-relations-tab-according-to-figma-mockups
bsatarnejad
force-pushed
the
58734-extract-work-package-info-line-into-a-primer-component-and-document-it
branch
2 times, most recently
from
b95270e to
c5affce
Compare
HDinger
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Hi @bsatarnejad
I have some smaller wishes for improvement for the component. Further, please also update the other occurences of the InfoLine that we are already aware of, in this PR (meetings, hovercard, ...)
Comment on lines
3
to
17
| flex.with_column(mr: 2) do | ||
| render(WorkPackages::HighlightedTypeComponent.new(work_package: @work_package, font_size: :small)) | ||
| end | ||
| flex.with_column(mr: 2) do | ||
| render(Primer::Beta::Text.new(font_size: :small, color: :muted)) { "##{@work_package.id}" } | ||
| end | ||
| flex.with_column do | ||
| render WorkPackages::StatusBadgeComponent.new(status: @work_package.status) | ||
| end |
There was a problem hiding this comment.
Currently, the font-size is always set to small and the ID always muted. I guess, it makes sense to make at least the font_size configurable. The default could still be small.
3 tasks
bsatarnejad
force-pushed
the
58734-extract-work-package-info-line-into-a-primer-component-and-document-it
branch
from
2f0c893 to
ad8f439
Compare
bsatarnejad
merged commit 8f3bfe7
into
implementation/58345-re-design-relations-tab-according-to-figma-mockups
5 of 6 checks passed
bsatarnejad
deleted the
58734-extract-work-package-info-line-into-a-primer-component-and-document-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/58734/activity
What are you trying to accomplish?
Make a separate component that shows type, ID and status of a WP in one line. Therefore, this component can be used in different places like meeting agenda item, hover card, ...
Screenshots
Before:
After:
Merge checklist