Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about overriding connection on backend-test #17257

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

brunopagno
Copy link
Contributor

What are you trying to accomplish?

Documentation update because I had issues.

@brunopagno brunopagno requested a review from a team November 22, 2024 14:15
@brunopagno brunopagno self-assigned this Nov 22, 2024
@@ -218,6 +218,16 @@ you want to see what the browsers are doing. `gvncviewer` or `vinagre` on Linux
the `docker-compose.override.yml` to access a container of a specific browser. As a default, the `chrome` container is
exposed on port 5900. The password is `secret` for all.

Bear in mind that overriding the network for `backend-test`, might cause issues with selenium connecting to the browser.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephrase that into s.th. like:

Adding additional external docker networks to the test services like backend-test (e.g. inside the docker-compose.override.yml) breaks the functionality of the Selenium service. This results in failing tests running inside a Selenium context, like feature and UI tests.

(Session info: chrome=130.0.6723.91)
```

If this happend just comment out the network overrides
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing .

@brunopagno brunopagno requested a review from Kharonus November 23, 2024 10:16
@brunopagno brunopagno merged commit b9c6174 into dev Dec 2, 2024
3 checks passed
@brunopagno brunopagno deleted the docs/include-note-about-selenium-on-docker branch December 2, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants