Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#59037] Primerize "Log time" dialog #17268

Draft
wants to merge 58 commits into
base: dev
Choose a base branch
from
Draft

[#59037] Primerize "Log time" dialog #17268

wants to merge 58 commits into from

Conversation

klaustopher
Copy link
Contributor

@klaustopher klaustopher commented Nov 25, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/59037

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

ToDos

  • User input field generates the wrong input name for the hidden input. Should be time_entry[custom_field_values][14][] is timeentry[custom_field_values][14][]
  • User select adds an empty component wrapper for the hidden input field, this shows up in the UI as a seperator

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch 9 times, most recently from 1b80f81 to c1fe43b Compare December 3, 2024 08:58
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch 6 times, most recently from 99ba88e to 5365457 Compare December 10, 2024 10:17
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 10:31 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 6d8d0cc to 2a5815e Compare December 10, 2024 15:19
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 15:19 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 2a5815e to b4eda15 Compare December 10, 2024 15:35
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 15:35 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 10, 2024 16:18 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 286eb05 to 3bcc56f Compare December 11, 2024 09:02
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 11, 2024 09:03 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 11, 2024 15:55 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 5f3398a to 82be505 Compare December 11, 2024 15:55
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 11, 2024 16:09 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 12, 2024 09:52 Inactive
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 6080475 to 5c36cf0 Compare December 12, 2024 11:22
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17268 December 12, 2024 11:23 Inactive
@klaustopher
use the proper date picker
9e37a6c
@klaustopher
enable time inputs and fix CSS for time pickers
44e248a 
The CSS change came from #8755. The CSS fix seems not to be needed anymore, as
removing this CSS does not re-introduce the bug marked in the WorkPackage
@klaustopher
method to show caption when we are +1 day
975dc48
@klaustopher
Add conversion from HH:mm format to integer
a747501
@klaustopher
add functionality to chronic duration to parse 8:15 to 8hours 15minut…
328eee8 
…es instead of 8minutes 15seconds
@klaustopher
add time calculation logic
d005f3f
@klaustopher
switch to native html time input element
459266a
@klaustopher
fix behavior when we have disabled time tracking inputs
fafe888
@klaustopher
make rubocop happy
f0a4eed
@klaustopher
use i18n for day diff
32389e0
@klaustopher
render chronic duration in input field so that input does not suddenl…
a65782a 
…y change
@klaustopher
Make the dialog more usable
e28064c
@klaustopher
fix form handling
98a0ba2
@klaustopher
more links for temporary logging time
034eeea
@klaustopher
split form into seperate fields
1227af2
@klaustopher
use specific work package apis and call turbo action to replace activ…
bcc272d 
…ities
@klaustopher
render the activity form
f59236d
@klaustopher
remove label
f2e5b3e
@klaustopher
Add the new dialog the calendar widget
7f49889
@klaustopher
remove temporary links from overview
897e866
@klaustopher
add new time entry modal to the context menu within a work package
5d2ec6c
@klaustopher
use the new dialog in the costs report as well
022e6d8
@klaustopher
extract finder stuff into before actions
834bd28
@klaustopher klaustopher force-pushed the implementation/59037-primerize-log-time-dialog branch from 68695be to 834bd28 Compare December 17, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pullpreview
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klaustopher @dombesz